From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946200AbcBSLpR (ORCPT ); Fri, 19 Feb 2016 06:45:17 -0500 Received: from trem.minaslivre.org ([148.251.208.85]:54995 "EHLO grilo.cascardo.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1427711AbcBSLpM (ORCPT ); Fri, 19 Feb 2016 06:45:12 -0500 X-Greylist: delayed 577 seconds by postgrey-1.27 at vger.kernel.org; Fri, 19 Feb 2016 06:45:12 EST Date: Fri, 19 Feb 2016 09:35:25 -0200 From: Thadeu Lima de Souza Cascardo To: Amitoj Kaur Chawla Cc: cascardo@linux.vnet.ibm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] ehea: Drop owner assignment from platform_driver Message-ID: <20160219113524.GR4148@siri.cascardo.eti.br> References: <20160219112219.GA2366@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160219112219.GA2366@amitoj-Inspiron-3542> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 19, 2016 at 04:52:19PM +0530, Amitoj Kaur Chawla wrote: > platform_driver does not need to set an owner, it will be populated by > the driver core. > > Generated-by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > Signed-off-by: Amitoj Kaur Chawla > --- > drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c > index 2a0dc12..d4b022f 100644 > --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c > +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c > @@ -127,7 +127,6 @@ static const struct of_device_id ehea_device_table[] = { > static struct platform_driver ehea_driver = { > .driver = { > .name = "ehea", > - .owner = THIS_MODULE, > .of_match_table = ehea_device_table, > }, > .probe = ehea_probe_adapter, > -- > 1.9.1 > NACK. ehea does not use platform_driver_register, it uses ibmebus_register_driver, which does not set owner. Cascardo.