From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753179AbcBURYd (ORCPT ); Sun, 21 Feb 2016 12:24:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46631 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbcBURYb (ORCPT ); Sun, 21 Feb 2016 12:24:31 -0500 Date: Sun, 21 Feb 2016 18:15:35 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com, Andi Kleen Subject: Re: [PATCH 3/6] perf, tools, stat: Support metrics in --per-core/socket mode Message-ID: <20160221171535.GC10701@krava.homerouter.cpe> References: <1455749045-18098-1-git-send-email-andi@firstfloor.org> <1455749045-18098-4-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455749045-18098-4-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 17, 2016 at 02:44:02PM -0800, Andi Kleen wrote: SNIP > @@ -892,7 +908,10 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval, > struct perf_stat_output_ctx out; > struct outstate os = { > .fh = stat_config.output, > - .prefix = prefix ? prefix : "" > + .prefix = prefix ? prefix : "", > + .id = id, > + .nr = nr, > + .evsel = counter, > }; > print_metric_t pm = print_metric_std; > void (*nl)(void *); > @@ -962,15 +981,38 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval, > > perf_stat__print_shadow_stats(counter, uval, > stat_config.aggr_mode == AGGR_GLOBAL ? 0 : > - cpu_map__id_to_cpu(id), > + first_shadow_cpu(counter, id), hum, IIUC you need to handle AGGR_NONE in here as well? thanks, jirka