From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752357AbcBUXnF (ORCPT ); Sun, 21 Feb 2016 18:43:05 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:40410 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbcBUXnD (ORCPT ); Sun, 21 Feb 2016 18:43:03 -0500 Date: Sun, 21 Feb 2016 23:42:44 +0000 From: One Thousand Gnomes To: Andrej Krpic Cc: linux-kernel@vger.kernel.org, jslaby@suse.com, gregkh@linuxfoundation.org Subject: Re: [PATCH 0/8] tty: n_gsm: Make mux work as a responder station Message-ID: <20160221234244.175a445c@lxorguk.ukuu.org.uk> In-Reply-To: <1456090717-19913-1-git-send-email-ak77@tnode.com> References: <1456090717-19913-1-git-send-email-ak77@tnode.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 21 Feb 2016 22:38:29 +0100 Andrej Krpic wrote: > When using n_gsm you have to explicitly set it to work as a initiator > station. This led me to believe that it can also work as a responder. > > In a use case where I needed responder station mux I came to the > conclusion that it actually does not work. Second and third patch > fix dealings with frame C/R bit that then enable mux to work as a > responder station. > > Next patches in the series then fix bugs that were found after two > instances of n_gsm connected over null-modem cable were used. > > First patch fixes formatting errors, such as space before comma, and > most of the warnings reported by the checkpatch script. This looks reasonable to me. It was never intended to work as a responder but it seems clean enough to do so. Have you tested it against some other modems with these changes applied ? (I'm always wary of patches to this going in without testing on actual modems, because the spec is complex and we are not the only ones with bugs) Also can you please cc these patches to xinhuix.pan@intel.com Thanks Alan