From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753425AbcBVRq5 (ORCPT ); Mon, 22 Feb 2016 12:46:57 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:51240 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751430AbcBVRq4 (ORCPT ); Mon, 22 Feb 2016 12:46:56 -0500 Date: Mon, 22 Feb 2016 12:46:51 -0500 (EST) Message-Id: <20160222.124651.135368011882918651.davem@davemloft.net> To: sudipm.mukherjee@gmail.com Cc: w-kwok2@ti.com, m-karicheri2@ti.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, john.r.fastabend@intel.com Subject: Re: [PATCH] netcp: use pointer to fix build fail From: David Miller In-Reply-To: <1456161943-9206-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1456161943-9206-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 22 Feb 2016 09:46:55 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sudip Mukherjee Date: Mon, 22 Feb 2016 22:55:43 +0530 > While building keystone_defconfig of arm we are getting build failure > with the error: ... > The callback of ndo_setup_tc should be: > int (*ndo_setup_tc)(struct net_device *dev, u32 handle, __be16 protocol, > struct tc_to_netdev *tc); > > But we missed marking the last argument as a pointer. > > Fixes: 16e5cc647173 ("net: rework setup_tc ndo op to consume general tc operand") > CC: John Fastabend > Signed-off-by: Sudip Mukherjee Applied, thanks.