From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752567AbcBVABM (ORCPT ); Sun, 21 Feb 2016 19:01:12 -0500 Received: from 1.mo4.mail-out.ovh.net ([178.33.248.196]:49045 "EHLO 1.mo4.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752520AbcBVABL (ORCPT ); Sun, 21 Feb 2016 19:01:11 -0500 Date: Mon, 22 Feb 2016 01:01:07 +0100 From: Philippe Loctaux To: Joe Perches Cc: jbacik@fb.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Btrfs: ctree: added lines after variable declarations Message-ID: <20160222000107.GA11444@carbon.home> References: <1456098390-9859-1-git-send-email-phil@philippeloctaux.com> <1456098784.31061.10.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1456098784.31061.10.camel@perches.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Ovh-Tracer-Id: 5747437551035389431 X-Ovh-Remote: 86.253.201.12 (lfbn-1-1342-12.w86-253.abo.wanadoo.fr) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: 0 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeekjedrheefucetufdoteggodftvfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecu X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeekjedrheefgddujeejucetufdoteggodftvfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Is there no need of additional blank line here particulary or in all lines that I changed? -- Philippe Loctaux phil@philippeloctaux.com On Sun, Feb 21, 2016 at 03:53:04PM -0800, Joe Perches wrote: > On Mon, 2016-02-22 at 00:46 +0100, Philippe Loctaux wrote: > > Added lines after variable declarations, fixing 22 checkpatch warnings. > [] > > diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c > [] > > @@ -4592,6 +4610,7 @@ void btrfs_truncate_item(struct btrfs_root *root, struct btrfs_path *path, > >         data_end, old_data_start + new_size - data_end); > >   } else { > >   struct btrfs_disk_key disk_key; > > + > >   u64 offset; > > Overzealous here. > No additional blank line required. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html