From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753168AbcBVCyU (ORCPT ); Sun, 21 Feb 2016 21:54:20 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54482 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753085AbcBVCyQ (ORCPT ); Sun, 21 Feb 2016 21:54:16 -0500 Date: Mon, 22 Feb 2016 11:53:51 +0900 From: Mark Brown To: Lars-Peter Clausen Cc: Robert Jarzmik , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Message-ID: <20160222025351.GM18327@sirena.org.uk> References: <1455997470-12307-1-git-send-email-robert.jarzmik@free.fr> <56C98DA3.4000701@metafoo.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4dlmIwqylWgRDx7z" Content-Disposition: inline In-Reply-To: <56C98DA3.4000701@metafoo.de> X-Cookie: Adapt. Enjoy. Survive. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 175.126.181.186 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [alsa-devel] [PATCH v2] ASoC: wm9713: fix regmap free path X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4dlmIwqylWgRDx7z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Feb 21, 2016 at 11:12:51AM +0100, Lars-Peter Clausen wrote: > On 02/20/2016 08:44 PM, Robert Jarzmik wrote: > > Fix this by removing the doubled regmap free. > The correct fix is to use the non devm variant of regmap_init_ac97() in this > case. Device managed functions should only be used from inside a struct > device probe function. Gah, didn't notice that we allocate in the non-default probe function :/ Dropped. --4dlmIwqylWgRDx7z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWyng+AAoJECTWi3JdVIfQ4MsH/AtTtAZ54y4G8c8zPORC8567 rIRfz4mYzO/u20UdPM0GTd5bbpFfhKy1Cq9RWygj8c45cJ9EGvzA3/5YqxX0qxq+ GJMD61vrZBVQrKlRYEyEw/mNxTnvCi2Z04MO3C7NdrkHQqOH6KbeVXFobCMTYe9q S7udqcylh7u+WALXUVJOe/pRSG8fYkENihI/Jw+SeYX9IfMT7iHuXDhMytX3tE69 anMsEuDY/0mjLdVcTbJib7VogAzH2qtITVnGGf+FOoR+F0ax6rqaV7UpO31Ww6Ve MTYRy5vjjWUY7X/B9U2l2c4brNZaVWctQ5gg2mGDVqoevvQNPxH8wLLlIVwNarU= =d88V -----END PGP SIGNATURE----- --4dlmIwqylWgRDx7z--