From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753445AbcBVGtk (ORCPT ); Mon, 22 Feb 2016 01:49:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51123 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbcBVGtj (ORCPT ); Mon, 22 Feb 2016 01:49:39 -0500 Date: Mon, 22 Feb 2016 07:49:33 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Andi Kleen Subject: Re: [PATCH v2 3/5] perf tools: Update srcline/file if needed Message-ID: <20160222064933.GA2974@krava.homerouter.cpe> References: <20160221173904.GH10701@krava.homerouter.cpe> <1456101111-14400-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456101111-14400-1-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2016 at 09:31:51AM +0900, Namhyung Kim wrote: > Normally the hist entry's srcline and/or srcfile is set during sorting. > However sometime it's possible to a hist entry's srcline is not set yet > after the sorting. This is because the entry is so unique and other > sort keys already make it distinct. Then the srcline/file sort didn't > have a chance to be called during the sorting. In that case it has NULL > srcline/srcfile field and shows nothing. > > Before: > > $ perf report -s comm,sym,srcline > ... > Overhead Command Symbol > ----------------------------------------------------------------- > 34.42% swapper [k] intel_idle intel_idle.c:0 > 2.44% perf [.] __poll_nocancel (null) > 1.70% gnome-shell [k] fw_domains_get (null) > 1.04% Xorg [k] sock_poll (null) > > After: > > 34.42% swapper [k] intel_idle intel_idle.c:0 > 2.44% perf [.] __poll_nocancel .:0 > 1.70% gnome-shell [k] fw_domains_get fw_domains_get+42 > 1.04% Xorg [k] sock_poll socket.c:0 > > Signed-off-by: Namhyung Kim Acked-by: Jiri Olsa thanks, jirka