From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753830AbcBVRw6 (ORCPT ); Mon, 22 Feb 2016 12:52:58 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:44831 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751430AbcBVRwz (ORCPT ); Mon, 22 Feb 2016 12:52:55 -0500 Date: Mon, 22 Feb 2016 10:52:45 -0700 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: James Morris , linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, Wilck@intel.com, Martin Subject: Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5 Message-ID: <20160222175245.GA22828@obsidianresearch.com> References: <20160220081705.GA12981@intel.com> <20160222145023.GA28365@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160222145023.GA28365@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2016 at 04:50:23PM +0200, Jarkko Sakkinen wrote: > I already pushed a fix to my master for this issue: > > https://github.com/jsakkine/linux-tpmdd/commit/6386544ad7bceb3d0248b85da29d4d99eebe9161 The goal is to reduce the number of #ifdef'd code segments so we have fewer problems in future with a large .config test matrix. I'd rather see a __maybe_unused annotation instead. Jason