From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756145AbcBVW1b (ORCPT ); Mon, 22 Feb 2016 17:27:31 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:45353 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755495AbcBVW11 (ORCPT ); Mon, 22 Feb 2016 17:27:27 -0500 Date: Mon, 22 Feb 2016 14:27:20 -0800 From: Darren Hart To: Wolfram Sang Cc: platform-driver-x86@vger.kernel.org, Alex Hung , linux-kernel@vger.kernel.org Subject: Re: [PATCH] intel-hid: allocate correct amount of memory for private struct Message-ID: <20160222222720.GE14101@dvhart-mobl5.amr.corp.intel.com> References: <1456064574-11245-1-git-send-email-wsa@the-dreams.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456064574-11245-1-git-send-email-wsa@the-dreams.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 21, 2016 at 03:22:27PM +0100, Wolfram Sang wrote: > We want the size of the struct, not of a pointer to it. To be future > proof, just dereference the pointer to get the desired type. > > Signed-off-by: Wolfram Sang Queued to testing. Thank you Wolfram. > --- > > Compile tested only. Found by static code analysis. > > drivers/platform/x86/intel-hid.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c > index e20f23e04c24ce..f93abc8c1424ad 100644 > --- a/drivers/platform/x86/intel-hid.c > +++ b/drivers/platform/x86/intel-hid.c > @@ -180,8 +180,7 @@ static int intel_hid_probe(struct platform_device *device) > return -ENODEV; > } > > - priv = devm_kzalloc(&device->dev, > - sizeof(struct intel_hid_priv *), GFP_KERNEL); > + priv = devm_kzalloc(&device->dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > return -ENOMEM; > dev_set_drvdata(&device->dev, priv); > -- > 2.7.0 > > -- Darren Hart Intel Open Source Technology Center