From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756409AbcBVXaE (ORCPT <rfc822;w@1wt.eu>);
	Mon, 22 Feb 2016 18:30:04 -0500
Received: from mga14.intel.com ([192.55.52.115]:10716 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755877AbcBVXaC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 22 Feb 2016 18:30:02 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,486,1449561600"; 
   d="scan'208";a="918809993"
Date: Mon, 22 Feb 2016 15:27:38 -0800
From: Yu-cheng Yu <yu-cheng.yu@intel.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH 04/10] x86/xsaves: Introduce a new check that allows
 correct xstates copy from kernel to user directly
Message-ID: <20160222232738.GB4259@test-lenovo>
References: <1456167528-3806-1-git-send-email-yu-cheng.yu@intel.com>
 <CALCETrWpetkx8gKDCMnfdf4oWGZUy5e8upZPY+_NiJGsQ8sB4w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrWpetkx8gKDCMnfdf4oWGZUy5e8upZPY+_NiJGsQ8sB4w@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 22, 2016 at 02:42:54PM -0800, Andy Lutomirski wrote:
> > +static int should_save_registers_directly(void)
> 
> I don't like the name of this function because:
> 
> > +{
> > +       /*
> > +        * In signal handling path, the kernel already checks if
> > +        * FPU instructions have been used before it calls
> > +        * copy_fpstate_to_sigframe(). We check this here again
> > +        * to detect any potential mis-use and saving invalid
> > +        * register values directly to a signal frame.
> > +        */
> > +       WARN_ONCE(!current->thread.fpu.fpstate_active,
> > +                 "direct FPU save with no math use\n");
> 
> ... Here "direct" seems to mean that we're asking whether to directly save ...
> 
> > +
> > +       /*
> > +        * In the case that we are using a compacted kernel
> > +        * xsave area, we can not copy the thread.fpu.state
> > +        * directly to userspace and *must* save it from the
> > +        * registers directly.
> > +        */
> 
> ... and here "directly" means *both* copying directly to userspace and
> saving using xsave directly.
> 
> So can you rename it to something with an obvious meaning like
> "may_memcpy_fpu_regs" or similar?

This function determines whether the kernel should do
copy_fpregs_to_sigframe(). Perhaps we can re-name it to
may_copy_fpregs_to_sigframe()?

--Yu-cheng