From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932680AbcBWHhZ (ORCPT ); Tue, 23 Feb 2016 02:37:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36284 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932438AbcBWHhY (ORCPT ); Tue, 23 Feb 2016 02:37:24 -0500 Date: Tue, 23 Feb 2016 08:37:20 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com, Andi Kleen Subject: Re: [PATCH 3/6] perf, tools, stat: Support metrics in --per-core/socket mode Message-ID: <20160223073720.GA29163@krava.redhat.com> References: <1455749045-18098-1-git-send-email-andi@firstfloor.org> <1455749045-18098-4-git-send-email-andi@firstfloor.org> <20160221171535.GC10701@krava.homerouter.cpe> <20160222165202.GI5083@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160222165202.GI5083@two.firstfloor.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2016 at 05:52:02PM +0100, Andi Kleen wrote: > On Sun, Feb 21, 2016 at 06:15:35PM +0100, Jiri Olsa wrote: > > On Wed, Feb 17, 2016 at 02:44:02PM -0800, Andi Kleen wrote: > > > > SNIP > > > > > @@ -892,7 +908,10 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval, > > > struct perf_stat_output_ctx out; > > > struct outstate os = { > > > .fh = stat_config.output, > > > - .prefix = prefix ? prefix : "" > > > + .prefix = prefix ? prefix : "", > > > + .id = id, > > > + .nr = nr, > > > + .evsel = counter, > > > }; > > > print_metric_t pm = print_metric_std; > > > void (*nl)(void *); > > > @@ -962,15 +981,38 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval, > > > > > > perf_stat__print_shadow_stats(counter, uval, > > > stat_config.aggr_mode == AGGR_GLOBAL ? 0 : > > > - cpu_map__id_to_cpu(id), > > > + first_shadow_cpu(counter, id), > > > > hum, IIUC you need to handle AGGR_NONE in here as well? > > AFAIK it works. aggr_get_id in first_shadow_cpu and cpu_map__id_to_cpu > handle this case, right? it does not look like.. however it'll be more clear once there's the doc/comment about used cpus for aggr modes I asked for in here: http://marc.info/?l=linux-kernel&m=145607533503803&w=2 thanks, jirka