From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752049AbcBWNM6 (ORCPT ); Tue, 23 Feb 2016 08:12:58 -0500 Received: from smtprelay0206.hostedemail.com ([216.40.44.206]:46315 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751495AbcBWNM5 (ORCPT ); Tue, 23 Feb 2016 08:12:57 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3868:3872:4321:5007:6261:7875:7903:10004:10400:10848:10967:11026:11232:11658:11914:12043:12517:12519:12555:12740:13069:13311:13357:14096:14097:14659:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: spot07_1987bcbcf1c59 X-Filterd-Recvd-Size: 1883 Date: Tue, 23 Feb 2016 08:12:52 -0500 From: Steven Rostedt To: Peter Zijlstra Cc: LKML , Juri Lelli , Ingo Molnar , Clark Williams , Daniel Bristot de Oliveira , John Kacur Subject: Re: [PATCH] sched/deadline: Always calculate end of period on sched_yield() Message-ID: <20160223081252.59882ec7@gandalf.local.home> In-Reply-To: <20160223122822.GP6357@twins.programming.kicks-ass.net> References: <20160212181020.7dbaf326@gandalf.local.home> <20160223122822.GP6357@twins.programming.kicks-ass.net> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Feb 2016 13:28:22 +0100 Peter Zijlstra wrote: > On Fri, Feb 12, 2016 at 06:10:20PM -0500, Steven Rostedt wrote: > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > > index cd64c979d0e1..1dd180cda574 100644 > > --- a/kernel/sched/deadline.c > > +++ b/kernel/sched/deadline.c > > @@ -735,7 +735,7 @@ static void update_curr_dl(struct rq *rq) > > * approach need further study. > > */ > > delta_exec = rq_clock_task(rq) - curr->se.exec_start; > > - if (unlikely((s64)delta_exec <= 0)) > > + if (unlikely((s64)delta_exec <= 0 && !dl_se->dl_yielded)) > > return; > > > > schedstat_set(curr->se.statistics.exec_max, > > > Would something like this make sense instead? > I'll test it and see if it works. -- Steve