From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753583AbcBWI5s (ORCPT ); Tue, 23 Feb 2016 03:57:48 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:45397 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751198AbcBWI5r (ORCPT ); Tue, 23 Feb 2016 03:57:47 -0500 Date: Tue, 23 Feb 2016 09:57:40 +0100 From: Sascha Hauer To: Fabio Estevam Cc: shawnguo@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wolfgang.netbal@sigmatek.at, Fabio Estevam , stable@vger.kernel.org Subject: Re: [PATCH] bus: imx-weim: Take the 'status' property value into account Message-ID: <20160223085740.GC3939@pengutronix.de> References: <1456142513-12876-1-git-send-email-festevam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456142513-12876-1-git-send-email-festevam@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:56:58 up 5 days, 20:41, 32 users, load average: 0.01, 0.06, 0.05 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2016 at 09:01:53AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Currently we have an incorrect behaviour when multiple devices > are present under the weim node. For example: > > &weim { > ... > status = "okay"; > > sram@0,0 { > ... > status = "okay"; > }; > > mram@0,0 { > ... > status = "disabled"; > }; > }; > > In this case only the 'sram' device should be probed and not 'mram'. > > However what happens currently is that the status variable is ignored, > causing the 'sram' device to be disabled and 'mram' to be enabled. > > Change the weim_parse_dt() function to use > for_each_available_child_of_node()so that the devices marked with > 'status = disabled' are not probed. > > Cc: > Suggested-by: Wolfgang Netbal > Signed-off-by: Fabio Estevam > --- > drivers/bus/imx-weim.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Seems to be the right thing to do. Reviewed-by: Sascha Hauer Sascha > > diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c > index e98d15e..1827fc4 100644 > --- a/drivers/bus/imx-weim.c > +++ b/drivers/bus/imx-weim.c > @@ -150,7 +150,7 @@ static int __init weim_parse_dt(struct platform_device *pdev, > return ret; > } > > - for_each_child_of_node(pdev->dev.of_node, child) { > + for_each_available_child_of_node(pdev->dev.of_node, child) { > if (!child->name) > continue; > > -- > 1.9.1 > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |