From: Johannes Thumshirn <jthumshirn@suse.de>
To: "Ewan D. Milne" <emilne@redhat.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
wuninsu@gmail.com, thenzl@redhat.com,
sreekanth.reddy@avagotech.com, MPT-FusionLinux.pdl@avagotech.com,
taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu,
changwoo@gatech.edu
Subject: Re: [PATCH v3] mptbase: fixup error handling paths in mpt_attach()
Date: Tue, 23 Feb 2016 15:29:14 +0100 [thread overview]
Message-ID: <20160223142914.GB7128@c203.arch.suse.de> (raw)
In-Reply-To: <1456236012-27300-1-git-send-email-emilne@redhat.com>
On Tue, Feb 23, 2016 at 09:00:12AM -0500, Ewan D. Milne wrote:
> From: "Ewan D. Milne" <emilne@redhat.com>
>
> mpt_attach() was not checking for the failure to create fw_event_q.
> Also, iounmap() was not being called in all error cases after ioremap()
> had been called by mpt_mapresources().
>
> Reported-by: Insu Yun <wuninsu@gmail.com>
> Reviewed-by: Tomas Henzl <thenzl@redhat.com>
> Signed-off-by: Ewan D. Milne <emilne@redhat.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2016-02-23 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:00 Ewan D. Milne
2016-02-23 14:29 ` Johannes Thumshirn [this message]
2016-02-23 22:47 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223142914.GB7128@c203.arch.suse.de \
--to=jthumshirn@suse.de \
--cc=MPT-FusionLinux.pdl@avagotech.com \
--cc=changwoo@gatech.edu \
--cc=emilne@redhat.com \
--cc=insu@gatech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sreekanth.reddy@avagotech.com \
--cc=taesoo@gatech.edu \
--cc=thenzl@redhat.com \
--cc=wuninsu@gmail.com \
--cc=yeongjin.jang@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®