From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754374AbcBWQQJ (ORCPT ); Tue, 23 Feb 2016 11:16:09 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:52176 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753319AbcBWQQH (ORCPT ); Tue, 23 Feb 2016 11:16:07 -0500 Date: Tue, 23 Feb 2016 16:15:19 +0000 From: One Thousand Gnomes To: Tony Lindgren Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator enable Message-ID: <20160223161519.32dd296f@lxorguk.ukuu.org.uk> In-Reply-To: <20160223161034.GZ13417@atomide.com> References: <1456235876-4088840-1-git-send-email-arnd@arndb.de> <1456235876-4088840-4-git-send-email-arnd@arndb.de> <20160223161034.GZ13417@atomide.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > It is not easy to propagate that return code to the callers in > > uart_configure_port/uart_suspend_port/uart_resume_port, unless > > we change all UART drivers, and it is unclear what those would > > do with the return code. > > > > Instead, this patch uses a runtime warning to replace the > > compiletime warning. I have checked that the regulator in question > > is hardcoded to a fixed-voltage GPIO regulator, and that should > > never fail to get enabled if I understand the code right. > > Looks OK to me: If it was a concern for a real driver I think I'd perform a hangup on the port at that moment. That's what happens if for example you hot unplug a serial port which would be approximately the same as finding out you can't power it back up. Alan