From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754473AbcBWRYu (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Feb 2016 12:24:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52268 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754091AbcBWRYs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Feb 2016 12:24:48 -0500
Date: Tue, 23 Feb 2016 18:24:37 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Cody P Schafer <dev@codyps.com>,
        "David S. Miller" <davem@davemloft.net>, He Kuang <hekuang@huawei.com>,
        =?iso-8859-1?Q?J=E9r=E9mie?= Galarneau 
	<jeremie.galarneau@efficios.com>,
        Jiri Olsa <jolsa@kernel.org>, Kirill Smelkov <kirr@nexedi.com>,
        Li Zefan <lizefan@huawei.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, pi3orama@163.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/48] perf data: Support converting data from
 bpf_perf_event_output()
Message-ID: <20160223172437.GB16460@krava.redhat.com>
References: <1456132275-98875-1-git-send-email-wangnan0@huawei.com>
 <1456132275-98875-12-git-send-email-wangnan0@huawei.com>
 <20160223172346.GA16460@krava.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160223172346.GA16460@krava.redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 23, 2016 at 06:23:46PM +0100, Jiri Olsa wrote:
> On Mon, Feb 22, 2016 at 09:10:38AM +0000, Wang Nan wrote:
> 
> SNIP
> 
> > ---
> >  tools/perf/util/data-convert-bt.c | 112 +++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 111 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
> > index b722e57..70f462d 100644
> > --- a/tools/perf/util/data-convert-bt.c
> > +++ b/tools/perf/util/data-convert-bt.c
> > @@ -352,6 +352,84 @@ static int add_tracepoint_values(struct ctf_writer *cw,
> >  	return ret;
> >  }
> >  
> > +static int
> > +add_bpf_output_values(struct bt_ctf_event_class *event_class,
> > +		      struct bt_ctf_event *event,
> > +		      struct perf_sample *sample)
> > +{
> > +	struct bt_ctf_field_type *len_type, *seq_type;
> > +	struct bt_ctf_field *len_field, *seq_field;
> > +	unsigned int raw_size = sample->raw_size;
> > +	unsigned int nr_elements = raw_size / sizeof(u32);
> > +	unsigned int i;
> > +	int ret;
> > +
> > +	if (nr_elements * sizeof(u32) != raw_size)
> 
> could this be IS_ALIGNED(raw_size, u32)

nah we dont have it.. nevermind ;-)

jirka