From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757946AbcBXFVQ (ORCPT ); Wed, 24 Feb 2016 00:21:16 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57258 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757855AbcBXFVN (ORCPT ); Wed, 24 Feb 2016 00:21:13 -0500 Date: Tue, 23 Feb 2016 21:28:47 -0800 From: Andrew Morton To: Jessica Yu Cc: Rasmus Villemoes , Andy Shevchenko , Kees Cook , linux-kernel@vger.kernel.org Subject: Re: sscanf: implement basic character sets Message-Id: <20160223212847.905209b6.akpm@linux-foundation.org> In-Reply-To: <20160224051346.GD30919@packer-debian-8-amd64.digitalocean.com> References: <1456259902-31792-1-git-send-email-jeyu@redhat.com> <20160223140539.30a24c55c91a01ec51fd42ba@linux-foundation.org> <20160224051346.GD30919@packer-debian-8-amd64.digitalocean.com> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Feb 2016 00:13:47 -0500 Jessica Yu wrote: > >> This patch adds support for the '%[' conversion specifier for sscanf(). > >> This is useful in cases where we'd like to match substrings delimited by > >> something other than spaces. The original motivation for this patch > >> actually came from a livepatch discussion (See: https://lkml.org/lkml/2016/2/8/790), > >> where we were trying to come up with a clean way to parse symbol names with > >> substrings delimited by periods and commas. > > > > It would be better to include the justification right here in the > > changelog please. > > Not via some link-to-discussion and definitely not > > below the ^--- marker! It's very important. > > Thanks for the corrections Andrew. I am however slightly confused, are > you suggesting that I should provide a much more thorough explanation > about the motivation here in the changelog (below the ^--- marker), or > would this be better suited for a (separate) cover letter? Just in the plain old changelog is good - if it was in [0/n] I'd only move it into the changelog anyway. And 99.9% of the stuff people put below ^--- is useful so I always end up moving that into the changelog as well...