From: Francois Romieu <romieu@fr.zoreil.com>
To: Chunhao Lin <hau@realtek.com>
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.
Date: Tue, 23 Feb 2016 23:44:00 +0100 [thread overview]
Message-ID: <20160223224400.GA22343@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1456216103-8113-1-git-send-email-hau@realtek.com>
Chunhao Lin <hau@realtek.com> :
[...]
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 537974c..404be51 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
[...]
> @@ -7853,6 +7859,11 @@ static int rtl8169_runtime_suspend(struct device *device)
>
> rtl8169_net_suspend(dev);
>
> + /* Update counters before going runtime suspend */
> + if (netif_running(dev))
This test is useless (always true):
- rtl_open
[...]
pm_runtime_get_sync(&pdev->dev);
[...]
tp->TxDescArray = blah
[...]
- rtl8169_close
[...]
pm_runtime_get_sync(&pdev->dev);
[...]
tp->TxDescArray = NULL;
- rtl8169_runtime_suspend
[...]
if (!tp->TxDescArray)
return 0;
(the implicit smp barriers are mildly obvious, ok)
--
Ueimor
prev parent reply other threads:[~2016-02-23 22:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 8:28 Chunhao Lin
2016-02-23 22:44 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223224400.GA22343@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=hau@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®