From: Joel Becker <jlbec@evilplan.org>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, stoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 4/8] fs: configfs: Replace CURRENT_TIME by current_fs_time()
Date: Wed, 24 Feb 2016 09:02:18 +0000 [thread overview]
Message-ID: <20160224090218.GJ29804@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1456154274-30487-5-git-send-email-deepa.kernel@gmail.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
On Mon, Feb 22, 2016 at 07:17:50AM -0800, Deepa Dinamani wrote:
> CURRENT_TIME macro is not appropriate for filesystems as it
> doesn't use the right granularity for filesystem timestamps.
> Use current_fs_time() instead.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Cc: Joel Becker <jlbec@evilplan.org>
> Cc: stoph Hellwig <hch@lst.de>
> ---
> fs/configfs/inode.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/fs/configfs/inode.c b/fs/configfs/inode.c
> index cee087d..5f24ad3 100644
> --- a/fs/configfs/inode.c
> +++ b/fs/configfs/inode.c
> @@ -75,7 +75,8 @@ int configfs_setattr(struct dentry * dentry, struct iattr * iattr)
> sd_iattr->ia_mode = sd->s_mode;
> sd_iattr->ia_uid = GLOBAL_ROOT_UID;
> sd_iattr->ia_gid = GLOBAL_ROOT_GID;
> - sd_iattr->ia_atime = sd_iattr->ia_mtime = sd_iattr->ia_ctime = CURRENT_TIME;
> + sd_iattr->ia_atime = sd_iattr->ia_mtime =
> + sd_iattr->ia_ctime = current_fs_time(inode->i_sb);
> sd->s_iattr = sd_iattr;
> }
> /* attributes were changed atleast once in past */
> @@ -111,7 +112,8 @@ int configfs_setattr(struct dentry * dentry, struct iattr * iattr)
> static inline void set_default_inode_attr(struct inode * inode, umode_t mode)
> {
> inode->i_mode = mode;
> - inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
> + inode->i_atime = inode->i_mtime =
> + inode->i_ctime = current_fs_time(inode->i_sb);
> }
>
> static inline void set_inode_attr(struct inode * inode, struct iattr * iattr)
> @@ -195,7 +197,7 @@ int configfs_create(struct dentry * dentry, umode_t mode, void (*init)(struct in
> return -ENOMEM;
>
> p_inode = d_inode(dentry->d_parent);
> - p_inode->i_mtime = p_inode->i_ctime = CURRENT_TIME;
> + p_inode->i_mtime = p_inode->i_ctime = current_fs_time(p_inode->i_sb);
> configfs_set_inode_lock_class(sd, inode);
>
> init(inode);
> --
> 1.9.1
>
--
next prev parent reply other threads:[~2016-02-24 9:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 15:17 [PATCH 0/8] Remove CURRENT_TIME and CURRENT_TIME_SEC - PART 2 Deepa Dinamani
2016-02-22 15:17 ` [PATCH 1/8] fs: debugfs: Replace CURRENT_TIME by current_fs_time() Deepa Dinamani
2016-02-22 15:17 ` [PATCH 2/8] fs: logfs: " Deepa Dinamani
2016-02-22 15:17 ` [PATCH 3/8] fs: devpts: " Deepa Dinamani
2016-02-22 15:17 ` [PATCH 4/8] fs: configfs: " Deepa Dinamani
2016-02-24 9:02 ` Joel Becker [this message]
2016-02-26 9:45 ` stoph Hellwig
2016-02-22 15:17 ` [PATCH 5/8] fs: proc: " Deepa Dinamani
2016-02-22 15:17 ` [PATCH 6/8] fs: ramfs: " Deepa Dinamani
2016-02-22 15:17 ` [PATCH 7/8] fs: kernfs: " Deepa Dinamani
2016-02-22 15:17 ` [PATCH 8/8] net: sunrpc: " Deepa Dinamani
2016-02-22 15:34 ` Trond Myklebust
2016-02-22 15:47 ` Deepa Dinamani
2016-02-24 15:08 ` [Y2038] " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224090218.GJ29804@ZenIV.linux.org.uk \
--to=jlbec@evilplan.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome