From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758956AbcBYBpu (ORCPT ); Wed, 24 Feb 2016 20:45:50 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57492 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754253AbcBYBps (ORCPT ); Wed, 24 Feb 2016 20:45:48 -0500 Date: Wed, 24 Feb 2016 17:53:33 -0800 From: Andrew Morton To: Joonsoo Kim Cc: Michal Nazarewicz , Minchan Kim , Mel Gorman , Vlastimil Babka , "Kirill A. Shutemov" , Sergey Senozhatsky , Steven Rostedt , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v3 1/2] mm: introduce page reference manipulation functions Message-Id: <20160224175333.8957903d.akpm@linux-foundation.org> In-Reply-To: <20160225003454.GB9723@js1304-P5Q-DELUXE> References: <1456212078-22732-1-git-send-email-iamjoonsoo.kim@lge.com> <20160223153244.83a5c3ca430c4248a4a34cc0@linux-foundation.org> <20160225003454.GB9723@js1304-P5Q-DELUXE> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Feb 2016 09:34:55 +0900 Joonsoo Kim wrote: > > > > The patches will be a bit of a pain to maintain but surprisingly they > > apply OK at present. It's possible that by the time they hit upstream, > > some direct ->_count references will still be present and it will > > require a second pass to complete the conversion. > > In fact, the patch doesn't change direct ->_count reference for > *read*. That's the reason that it is surprisingly OK at present. > > It's a good idea to change direct ->_count reference even for read. > How about changing it in rc2 after mering this patch in rc1? Sounds fair enough. Although I'm counting only 11 such sites so perhaps we just go ahead and do it?