From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751985AbcBYVTw (ORCPT ); Thu, 25 Feb 2016 16:19:52 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:46216 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbcBYVTt (ORCPT ); Thu, 25 Feb 2016 16:19:49 -0500 Date: Thu, 25 Feb 2016 16:19:47 -0500 (EST) Message-Id: <20160225.161947.854773663623773324.davem@davemloft.net> To: hau@realtek.com Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v4] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam. From: David Miller In-Reply-To: <1456294722-3596-1-git-send-email-hau@realtek.com> References: <1456294722-3596-1-git-send-email-hau@realtek.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 25 Feb 2016 13:19:48 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chunhao Lin Date: Wed, 24 Feb 2016 14:18:42 +0800 > There will be a log spam when there is no cable plugged. Please refer to > following links. https://bugzilla.kernel.org/show_bug.cgi?id=104351 > https://bugzilla.kernel.org/show_bug.cgi?id=107421 > > This issue is caused by runtime power management. When there is no cable > plugged, the driver will be suspend (runtime suspend) by OS and NIC will be > put into the D3 state. During this time, if OS call rtl8169_get_stats64() > to dump tally counter, because NIC is in D3 state, the register value read > by driver will return all 0xff. This will let driver think tally counter > flag is not toggled and then sends the warning message "rtl_counters_cond > == 1 (loop: 1000, delay: 10)" to kernel log. > > For fixing this issue, 1.add checking driver's pm runtime status in > rtl8169_get_stats64(). 2.dump tally counter before going runtime suspend > for counter accuracy in runtime suspend. > > Signed-off-by: Chunhao Lin Applied, thanks.