From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760783AbcBYPrq (ORCPT ); Thu, 25 Feb 2016 10:47:46 -0500 Received: from smtprelay0006.hostedemail.com ([216.40.44.6]:53446 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760202AbcBYPrp (ORCPT ); Thu, 25 Feb 2016 10:47:45 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1434:1437:1515:1516:1518:1535:1544:1593:1594:1605:1711:1730:1747:1777:1792:1801:2393:2553:2559:2562:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3870:3871:4321:4605:5007:6261:7514:7875:8603:8660:8957:10004:10848:10967:11026:11232:11658:11914:12043:12295:12296:12438:12517:12519:12555:12740:13148:13230:14096:14097:14659:21080:21212:30029:30034:30051:30054:30080:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: knot67_263d694c1451f X-Filterd-Recvd-Size: 5985 Date: Thu, 25 Feb 2016 10:47:41 -0500 From: Steven Rostedt To: Taeung Song Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org, Thomas Gleixner , Lai Jiangshan Subject: Re: [PATCH RESEND 1/3] tracing/syscalls: Rename variable 'nr' to 'syscall_nr' Message-ID: <20160225104741.2cd3bf14@gandalf.local.home> In-Reply-To: <1456413858-13901-1-git-send-email-treeze.taeung@gmail.com> References: <1456413858-13901-1-git-send-email-treeze.taeung@gmail.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Feb 2016 00:24:18 +0900 Taeung Song wrote: > There is a problem about duplicated variable name > for system call number and a argument of some > system call. I found this problem when I tested > perf-script with python script as below. > > # perf record -e syscalls:* > # perf script -g python > # perf script -s perf-script.py > File "perf-script.py", line 8694 > def syscalls__sys_enter_io_getevents(event_name, context, common_cpu, > SyntaxError: duplicate argument 'nr' in function definition > Error running python script perf-script.py > > As above, problems about duplicated argument occurred > when processing sys_enter_io_getevent() and sys_enter_io_submit(). > Because the two system calls have a argument 'nr' as below. > > int io_getevents(aio_context_t ctx_id, long min_nr, long nr, > struct io_event *events, struct timespec *timeout); > > int io_submit(aio_context_t ctx_id, long nr, struct iocb **iocbpp); > > So rename a variable 'nr' to 'syscall_nr' for system call number > in print_syscall_enter(). WTF, how does changing the kernel fix a user space python generation bug? -- Steve > > Cc: Thomas Gleixner > Cc: Lai Jiangshan > Signed-off-by: Taeung Song > --- > kernel/trace/trace.h | 4 ++-- > kernel/trace/trace_syscalls.c | 16 ++++++++-------- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h > index 8414fa4..beddeb1 100644 > --- a/kernel/trace/trace.h > +++ b/kernel/trace/trace.h > @@ -88,13 +88,13 @@ enum trace_type { > */ > struct syscall_trace_enter { > struct trace_entry ent; > - int nr; > + int syscall_nr; > unsigned long args[]; > }; > > struct syscall_trace_exit { > struct trace_entry ent; > - int nr; > + int syscall_nr; > long ret; > }; > > diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c > index 0655afb..956209f 100644 > --- a/kernel/trace/trace_syscalls.c > +++ b/kernel/trace/trace_syscalls.c > @@ -118,7 +118,7 @@ print_syscall_enter(struct trace_iterator *iter, int flags, > int i, syscall; > > trace = (typeof(trace))ent; > - syscall = trace->nr; > + syscall = trace->syscall_nr; > entry = syscall_nr_to_meta(syscall); > > if (!entry) > @@ -164,7 +164,7 @@ print_syscall_exit(struct trace_iterator *iter, int flags, > struct syscall_metadata *entry; > > trace = (typeof(trace))ent; > - syscall = trace->nr; > + syscall = trace->syscall_nr; > entry = syscall_nr_to_meta(syscall); > > if (!entry) { > @@ -261,7 +261,7 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call) > int i; > int offset = offsetof(typeof(trace), args); > > - ret = trace_define_field(call, SYSCALL_FIELD(int, nr), FILTER_OTHER); > + ret = trace_define_field(call, SYSCALL_FIELD(int, syscall_nr), FILTER_OTHER); > if (ret) > return ret; > > @@ -281,7 +281,7 @@ static int __init syscall_exit_define_fields(struct trace_event_call *call) > struct syscall_trace_exit trace; > int ret; > > - ret = trace_define_field(call, SYSCALL_FIELD(int, nr), FILTER_OTHER); > + ret = trace_define_field(call, SYSCALL_FIELD(int, syscall_nr), FILTER_OTHER); > if (ret) > return ret; > > @@ -332,7 +332,7 @@ static void ftrace_syscall_enter(void *data, struct pt_regs *regs, long id) > return; > > entry = ring_buffer_event_data(event); > - entry->nr = syscall_nr; > + entry->syscall_nr = syscall_nr; > syscall_get_arguments(current, regs, 0, sys_data->nb_args, entry->args); > > event_trigger_unlock_commit(trace_file, buffer, event, entry, > @@ -378,7 +378,7 @@ static void ftrace_syscall_exit(void *data, struct pt_regs *regs, long ret) > return; > > entry = ring_buffer_event_data(event); > - entry->nr = syscall_nr; > + entry->syscall_nr = syscall_nr; > entry->ret = syscall_get_return_value(current, regs); > > event_trigger_unlock_commit(trace_file, buffer, event, entry, > @@ -579,7 +579,7 @@ static void perf_syscall_enter(void *ignore, struct pt_regs *regs, long id) > if (!rec) > return; > > - rec->nr = syscall_nr; > + rec->syscall_nr = syscall_nr; > syscall_get_arguments(current, regs, 0, sys_data->nb_args, > (unsigned long *)&rec->args); > perf_trace_buf_submit(rec, size, rctx, 0, 1, regs, head, NULL); > @@ -652,7 +652,7 @@ static void perf_syscall_exit(void *ignore, struct pt_regs *regs, long ret) > if (!rec) > return; > > - rec->nr = syscall_nr; > + rec->syscall_nr = syscall_nr; > rec->ret = syscall_get_return_value(current, regs); > perf_trace_buf_submit(rec, size, rctx, 0, 1, regs, head, NULL); > }