From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933311AbcBYRJM (ORCPT ); Thu, 25 Feb 2016 12:09:12 -0500 Received: from smtprelay0187.hostedemail.com ([216.40.44.187]:35208 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933237AbcBYRJK (ORCPT ); Thu, 25 Feb 2016 12:09:10 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1434:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:1801:2376:2393:2553:2559:2562:2689:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4605:5007:6261:7514:7875:8603:8660:9163:10004:10400:10848:10967:11026:11232:11658:11914:12043:12295:12296:12438:12517:12519:12663:12740:13138:13148:13230:13231:14096:14097:14659:21080:21212:21324:30029:30034:30054:30070:30080:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: wire17_159258596cf56 X-Filterd-Recvd-Size: 3244 Date: Thu, 25 Feb 2016 12:09:07 -0500 From: Steven Rostedt To: Taeung Song Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org, Thomas Gleixner , Lai Jiangshan Subject: Re: [PATCH RESEND 1/3] tracing/syscalls: Rename variable 'nr' to 'syscall_nr' Message-ID: <20160225120907.0a30d792@gandalf.local.home> In-Reply-To: <20160225120501.5a99408c@gandalf.local.home> References: <1456413858-13901-1-git-send-email-treeze.taeung@gmail.com> <20160225104741.2cd3bf14@gandalf.local.home> <56CF319B.8060806@gmail.com> <20160225120501.5a99408c@gandalf.local.home> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Feb 2016 12:05:01 -0500 Steven Rostedt wrote: > On Fri, 26 Feb 2016 01:53:47 +0900 > Taeung Song wrote: > > > > > The underlying cause of this problem is not because of > > the python script. This problem have relevance to tracing/syscalls > > as below. > > > > # cat > > /sys/kernel/debug/tracing/events/syscalls/sys_enter_io_getevents/format > > name: sys_enter_io_getevents > > ID: 739 > > format: > > field:unsigned short common_type; offset:0;size:2;signed:0; > > field:unsigned char common_flags; offset:2;size:1;signed:0; > > field:unsigned char common_preempt_count; offset:3;size:1;signed:0; > > field:int common_pid; offset:4;size:4;signed:1; > > field:int nr; offset:8;size:4;signed:1; > > field:aio_context_t ctx_id; offset:16;size:8;signed:0; > > field:long min_nr; offset:24;size:8;signed:0; > > field:long nr; offset:32;size:8;signed:0; > > field:struct io_event * events; offset:40;size:8;signed:0; > > field:struct timespec * timeout; offset:48;size:8;signed:0; > > > > print fmt: "ctx_id: 0x%08lx, min_nr: 0x%08lx, nr: 0x%08lx, events: > > 0x%08lx, timeout: 0x%08lx", ((unsigned long)(REC->ctx_id)), ((unsigned > > long)(REC->min_nr)), ((unsigned long)(REC->nr)), ((unsigned > > long)(REC->events)), ((unsigned long)(REC->timeout)) > > > > > > As you see, there are duplicated variable name among fields. > > So I renamed the variable name 'nr' to 'syscall_nr' to avoid this > > duplication. As you know 'nr' in print_syscall_enter() mean > > system call number so, I changed 'nr' to 'syscall_nr'(IMHO). > > > > The above should have been in the change log. That makes much more > sense. > I'm a bit nervous about this change though. Because it is an ABI change. Hopefully there's no tools that parse the syscall tracepoints and expect to find a 'nr' in there. -- Steve