From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760642AbcBYOTK (ORCPT ); Thu, 25 Feb 2016 09:19:10 -0500 Received: from casper.infradead.org ([85.118.1.10]:33686 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760148AbcBYOTI (ORCPT ); Thu, 25 Feb 2016 09:19:08 -0500 Date: Thu, 25 Feb 2016 15:18:59 +0100 From: Peter Zijlstra To: Alexei Starovoitov Cc: "David S. Miller" , Ingo Molnar , Steven Rostedt , Wang Nan , Daniel Borkmann , Brendan Gregg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/3] perf: generalize perf_callchain Message-ID: <20160225141859.GM6357@twins.programming.kicks-ass.net> References: <1455767939-2700534-1-git-send-email-ast@fb.com> <1455767939-2700534-2-git-send-email-ast@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455767939-2700534-2-git-send-email-ast@fb.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 17, 2016 at 07:58:57PM -0800, Alexei Starovoitov wrote: > . avoid walking the stack when there is no room left in the buffer > . generalize get_perf_callchain() to be called from bpf helper If it does two things it should be two patches. > Signed-off-by: Alexei Starovoitov > --- > arch/x86/include/asm/stacktrace.h | 2 +- > arch/x86/kernel/cpu/perf_event.c | 4 ++-- > arch/x86/kernel/dumpstack.c | 6 ++++-- > arch/x86/kernel/stacktrace.c | 18 +++++++++++------- > arch/x86/oprofile/backtrace.c | 3 ++- > include/linux/perf_event.h | 13 +++++++++++-- > kernel/events/callchain.c | 32 ++++++++++++++++++++------------ > kernel/events/internal.h | 2 -- > 8 files changed, 51 insertions(+), 29 deletions(-) And at the very least this should have had a note that it doesn't break all the other archs that implement perf-callchain stuff.