From: Peter Zijlstra <peterz@infradead.org>
To: luca abeni <luca.abeni@unitn.it>
Cc: Juri Lelli <juri.lelli@arm.com>, linux-kernel@vger.kernel.org
Subject: Re: Question about prio_changed_dl()
Date: Thu, 25 Feb 2016 15:52:02 +0100 [thread overview]
Message-ID: <20160225145202.GQ6356@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160225152558.2fbac9e5@utopia>
On Thu, Feb 25, 2016 at 03:25:58PM +0100, luca abeni wrote:
> > > (BTW, it seems to me that switched_to_dl() is never invoked, for
> > > some reason...)
> >
> > Hmm, it should be invoked if you do sched_setattr() to get
> > SCHED_DEADLINE.
>
> Sorry, that was me being confused...
> It is prio_changed_dl() that is not invoked when the deadline
> parameters are changed (I am testing a change to fix this - it actually
> is included in the "Move the remaining __dl_{sub,add}_ac() calls from
> core.c to deadline.c" patch I posted on Monday; I am going to extract
> it in a separate patch).
Ah ok. So the idea was that the || dl_task() part would ensure
->prio_changed() would always be called.
I'll await your patch.
next prev parent reply other threads:[~2016-02-25 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 12:43 luca abeni
2016-02-25 14:01 ` Peter Zijlstra
2016-02-25 14:16 ` Juri Lelli
2016-02-25 14:25 ` luca abeni
2016-02-25 14:52 ` Peter Zijlstra [this message]
2016-02-27 11:37 ` luca abeni
2016-03-02 19:02 ` Peter Zijlstra
2016-03-02 20:16 ` luca abeni
2016-03-02 20:58 ` Peter Zijlstra
2016-03-04 8:50 ` luca abeni
2016-02-29 11:19 ` [tip:sched/core] sched/deadline: Remove superfluous call to switched_to_dl() tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225145202.GQ6356@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@unitn.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome