mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Mikulas Patocka <mikulas@twibright.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hpfs: don't truncate the file when delete fails
Date: Thu, 25 Feb 2016 17:20:02 +0000	[thread overview]
Message-ID: <20160225172001.GX17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.00.1602251800130.10262@leontynka>

On Thu, Feb 25, 2016 at 06:17:38PM +0100, Mikulas Patocka wrote:
> The delete opration can allocate additional space on the HPFS filesystem
> due to btree split. The HPFS driver checks in advance if there is
> available space, so that it won't corrupt the btree if we run out of space
> during splitting.
> 
> If there is not enough available space, the HPFS driver attempted to
> truncate the file, but this results in a deadlock since the commit
> 7dd29d8d865efdb00c0542a5d2c87af8c52ea6c7 ("HPFS: Introduce a global mutex
> and lock it on every callback from VFS").
> 
> This patch removes the code that tries to truncate the file and -ENOSPC is
> returned instead. If the user hits -ENOSPC on delete, he should try to
> delete other files (that are stored in a leaf btree node), so that the
> delete operation will make some space for deleting the file stored in
> non-leaf btree node.
> 
> Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
> Signed-off-by: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
> Cc: stable@vger.kernel.org	# 2.6.39+

Picked, but I don't understand that Cc: stable...

  reply	other threads:[~2016-02-25 17:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 17:17 Mikulas Patocka
2016-02-25 17:20 ` Al Viro [this message]
2016-02-25 17:37   ` Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160225172001.GX17997@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikulas@twibright.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®