From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933372AbcBYSS1 (ORCPT ); Thu, 25 Feb 2016 13:18:27 -0500 Received: from mail-yw0-f196.google.com ([209.85.161.196]:33764 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933114AbcBYSSZ (ORCPT ); Thu, 25 Feb 2016 13:18:25 -0500 Date: Thu, 25 Feb 2016 13:18:22 -0500 From: Tejun Heo To: Ondrej Zary Cc: linux-ide@vger.kernel.org, Joseph Chan , Kernel development list Subject: Re: [PATCH v2] sata_via: Apply WD workaround only when needed on VT6421 Message-ID: <20160225181822.GA6092@mtj.duckdns.org> References: <1455966113-7320-1-git-send-email-linux@rainbow-software.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455966113-7320-1-git-send-email-linux@rainbow-software.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 20, 2016 at 12:01:53PM +0100, Ondrej Zary wrote: > Currently, workaround for broken WD drives is applied always, slowing > down all drives. And it has a bug - it's not applied after resume. > > Apply the workaround only if the error really appears > (SErr == 0x1000500). This allows unaffected drives to run at full speed > (provided that no affected drive is connected to the controller). > Also make sure the workaround is re-applied on resume. ... > Signed-off-by: Ondrej Zary Applied to libata/for-4.6. Thanks. -- tejun