From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933491AbcBYSUn (ORCPT ); Thu, 25 Feb 2016 13:20:43 -0500 Received: from down.free-electrons.com ([37.187.137.238]:52561 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933431AbcBYSUk (ORCPT ); Thu, 25 Feb 2016 13:20:40 -0500 Date: Thu, 25 Feb 2016 19:20:38 +0100 From: Alexandre Belloni To: Joshua Henderson Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alessandro Zummo , rtc-linux@googlegroups.com Subject: Re: [PATCH v3 2/2] rtc: rtc-pic32: Add PIC32 real time clock driver Message-ID: <20160225182038.GJ12073@piout.net> References: <1456421449-18225-2-git-send-email-joshua.henderson@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456421449-18225-2-git-send-email-joshua.henderson@microchip.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/02/2016 at 10:30:44 -0700, Joshua Henderson wrote : > This driver adds support for the PIC32 real time clock and calendar > peripheral: > - reading and setting time > - alarms provided by dedicated IRQ > > Signed-off-by: Joshua Henderson > --- > Changes since v2: > - Fix rework bug causing unecessary retries for gettime. > - Word commit message to be more precise. > Changes since v1: > - Fix checkpatch.pl --strict issues. > - Fix alpabetical makefile ordering. > - Specify consistent license. > - General formatting cleanup. > - Drop unecessary flags_lock. > - Replace ugly gogo with do while. > - Remove unecessary checks on time when setting alarm. > - Don't initialize the RTC in probe. > --- > drivers/rtc/Kconfig | 10 ++ > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-pic32.c | 411 +++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 422 insertions(+) > create mode 100644 drivers/rtc/rtc-pic32.c > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com