From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933562AbcBYTC1 (ORCPT ); Thu, 25 Feb 2016 14:02:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50505 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933286AbcBYTC0 (ORCPT ); Thu, 25 Feb 2016 14:02:26 -0500 Date: Thu, 25 Feb 2016 20:02:22 +0100 From: Jiri Olsa To: Taeung Song Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar Subject: Re: [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew() Message-ID: <20160225190222.GB4883@krava.redhat.com> References: <1456413190-12378-1-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456413190-12378-1-git-send-email-treeze.taeung@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2016 at 12:13:10AM +0900, Taeung Song wrote: > script_spec_register() called two functions > script_spec__find() and script_spec__findnew(). > But script_spec__find() was called two times. > > So remove script_spec__findnew() and make > script_spec_register() only call once script_spec__find(). > > Cc: Jiri Olsa > Signed-off-by: Taeung Song Acked-by: Jiri Olsa thanks, jirka