From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751094AbcBYU04 (ORCPT ); Thu, 25 Feb 2016 15:26:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57708 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbcBYU0y (ORCPT ); Thu, 25 Feb 2016 15:26:54 -0500 Date: Thu, 25 Feb 2016 14:26:50 -0600 From: Josh Poimboeuf To: Ingo Molnar Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Michal Marek , Peter Zijlstra , Andy Lutomirski , Borislav Petkov , Linus Torvalds , Andi Kleen , Pedro Alves , Namhyung Kim , Bernd Petrovitsch , Chris J Arges , Andrew Morton , Jiri Slaby , Arnaldo Carvalho de Melo Subject: Re: [PATCH v17 4/9] x86/objtool: Add STACK_FRAME_NON_STANDARD macro Message-ID: <20160225202650.GB5763@treble.redhat.com> References: <6b5098f327af4dfc11ad9bcdc274b0c8f0e2b2e5.1456331595.git.jpoimboe@redhat.com> <20160225075149.GA2354@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160225075149.GA2354@gmail.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 25 Feb 2016 20:26:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 25, 2016 at 08:51:49AM +0100, Ingo Molnar wrote: > > diff --git a/include/linux/objtool.h b/include/linux/objtool.h > > new file mode 100644 > > index 0000000..cce9d67 > > --- /dev/null > > +++ b/include/linux/objtool.h > > So I think this should really be in asm/frame.h, not in an objtool specific > header. I agree that it shouldn't be in an objtool-specific header, but asm/frame.h wouldn't work unless we added that file to all the arches. And the macro's functionality is arch-independent anyway. So I'm renaming the file to include/linux/frame.h. -- Josh