From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbcBYVUL (ORCPT ); Thu, 25 Feb 2016 16:20:11 -0500 Received: from mail-yk0-f194.google.com ([209.85.160.194]:33641 "EHLO mail-yk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbcBYVUI (ORCPT ); Thu, 25 Feb 2016 16:20:08 -0500 Date: Thu, 25 Feb 2016 16:20:00 -0500 From: Tejun Heo To: Laura Abbott Cc: Manuel Lauss , Linux-IDE , Linux Kernel Mailing List Subject: Re: [REGRESSION] 8a3e33cf92c7 "ata: ahci: find eSATA ports and flag them as removable" changes userspace behavior Message-ID: <20160225212000.GC6092@mtj.duckdns.org> References: <56CF35FA.1070500@redhat.com> <56CF57E5.7040808@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56CF57E5.7040808@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Laura. On Thu, Feb 25, 2016 at 11:37:09AM -0800, Laura Abbott wrote: > The mounting comes from udisks. udisks will automount anything marked as removable > unless explicitly forbidden. You can argue whether or not this is good design but > it's still a change in behavior from what udisks was relying on to decide > whether or not to automount. lspci from the users hardware: > > 00:1f.2 SATA controller: Intel Corporation C600/X79 series chipset 6-Port SATA > AHCI Controller (rev 06) It is a behavior change but difficult to characterize as a breakage, given that we do want userland to treat ports explicitly marked as external to be treated as such. That said, eSATA being mostly a fringe thing, we can go "whatever" and revert it. Let's hope it's a false positive that the patch can fix. Thanks. -- tejun