From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751992AbcBYVh4 (ORCPT ); Thu, 25 Feb 2016 16:37:56 -0500 Received: from mail-yw0-f169.google.com ([209.85.161.169]:33282 "EHLO mail-yw0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbcBYVhy (ORCPT ); Thu, 25 Feb 2016 16:37:54 -0500 Date: Thu, 25 Feb 2016 16:37:51 -0500 From: Tejun Heo To: Harvey Hunt Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, "# 2 . 6 . 18" Subject: Re: [PATCH] libata: Align ata_device's id on a cacheline Message-ID: <20160225213751.GH6092@mtj.duckdns.org> References: <1456327003-16295-1-git-send-email-harvey.hunt@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456327003-16295-1-git-send-email-harvey.hunt@imgtec.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 24, 2016 at 03:16:43PM +0000, Harvey Hunt wrote: > The id buffer in ata_device is a DMA target, but it isn't explicitly > cacheline aligned. Due to this, adjacent fields can be overwritten with > stale data from memory on non coherent architectures. As a result, the > kernel is sometimes unable to communicate with an ATA device. > > Fix this by ensuring that the id buffer is cacheline aligned. > > This issue is similar to that fixed by Commit 84bda12af31f > ("libata: align ap->sector_buf"). > > Signed-off-by: Harvey Hunt > Cc: linux-kernel@vger.kernel.org > Cc: # 2.6.18 Applied to libata/for-4.5-fixes. Thanks. -- tejun