From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751918AbcBYWC2 (ORCPT ); Thu, 25 Feb 2016 17:02:28 -0500 Received: from mail-oi0-f47.google.com ([209.85.218.47]:35458 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbcBYWC0 (ORCPT ); Thu, 25 Feb 2016 17:02:26 -0500 Date: Thu, 25 Feb 2016 16:02:24 -0600 From: Andy Gross To: Bjorn Andersson Cc: David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: qcom: smp2p: Use memset_io to zero out new entries Message-ID: <20160225220224.GA9986@hector.attlocal.net> References: <1456417057-17591-1-git-send-email-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456417057-17591-1-git-send-email-bjorn.andersson@linaro.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 25, 2016 at 08:17:37AM -0800, Bjorn Andersson wrote: > Signed-off-by: Bjorn Andersson > --- > drivers/soc/qcom/smp2p.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c > index f1eed7f9dd67..61df598444e6 100644 > --- a/drivers/soc/qcom/smp2p.c > +++ b/drivers/soc/qcom/smp2p.c > @@ -379,7 +379,7 @@ static int qcom_smp2p_alloc_outbound_item(struct qcom_smp2p *smp2p) > return PTR_ERR(out); > } > > - memset(out, 0, sizeof(*out)); > + memset_io(out, 0, sizeof(*out)); > out->magic = SMP2P_MAGIC; > out->local_pid = smp2p->local_pid; > out->remote_pid = smp2p->remote_pid; Good catch. I'll add this fix for the pull.