From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422932AbcBZUZW (ORCPT ); Fri, 26 Feb 2016 15:25:22 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:33240 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754786AbcBZUZV (ORCPT ); Fri, 26 Feb 2016 15:25:21 -0500 Date: Fri, 26 Feb 2016 15:25:19 -0500 (EST) Message-Id: <20160226.152519.25582868690139177.davem@davemloft.net> To: arnd@arndb.de Cc: Lada.Trimasova@synopsys.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey.Brodkin@synopsys.com, noamc@ezchip.com, talz@ezchip.com Subject: Re: [PATCH] net: ezchip: adapt driver to little endian architecture From: David Miller In-Reply-To: <24793363.yg41IbJKTo@wuerfel> References: <1456513509-30844-1-git-send-email-ltrimas@synopsys.com> <24793363.yg41IbJKTo@wuerfel> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 26 Feb 2016 12:25:20 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Fri, 26 Feb 2016 21:10:31 +0100 > On Friday 26 February 2016 22:05:09 Lada Trimasova wrote: >> for (i = 0; i < len; i++, reg++) { >> u32 buf = nps_enet_reg_get(priv, NPS_ENET_REG_RX_BUF); >> + buf = be32_to_cpu(buf); >> put_unaligned(buf, reg); >> } > > I think most of the changes can make use of the put_unaligned_be32() > etc helpers that might also be more efficient. Agreed.