From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894AbcBZB6f (ORCPT ); Thu, 25 Feb 2016 20:58:35 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:37372 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbcBZB6d (ORCPT ); Thu, 25 Feb 2016 20:58:33 -0500 Date: Fri, 26 Feb 2016 10:58:29 +0900 From: Mark Brown To: "Huang, Tao" Cc: Huibin Hong , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, "shawn.lin" , linux-rockchip@lists.infradead.org, Addy Ke Message-ID: <20160226015829.GC18327@sirena.org.uk> References: <1456308004-29102-1-git-send-email-huibin.hong@rock-chips.com> <56CD8F85.2090204@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/CMXFb8mCYhr2S8D" Content-Disposition: inline In-Reply-To: <56CD8F85.2090204@rock-chips.com> X-Cookie: Adapt. Enjoy. Survive. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 122.212.32.58 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/CMXFb8mCYhr2S8D Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 24, 2016 at 07:09:57PM +0800, Huang, Tao wrote: Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. > Another way to solve this bug is add runtime PM support while spi setup. > Some other chips may have some problem, for example mt65xx and orion, > which access hardware register too. No, this is telling you you're doing something wrong - setup() might be called while another transfer is in progress so you shouldn't be changing the hardware setup (see Documentation/spi/spi-summary). This means that you normally shouldn't be writing to registers there. Moving this to prepare_message() instead is probably what you want. --/CMXFb8mCYhr2S8D Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWz7FEAAoJECTWi3JdVIfQoM8H/1CE73Xyyf2R4+65oHHv/ISN RRSbDBOeGC4xi0Ci5p2mwSRQsG6Yj7RSv+k/L9qd1SoMu3CAgZkWYV8Stj0UczHl eatog3FiLzCc68NJcBvxL/7uzjY1UIZ+tZH8DkkD2GPJzjP1v6lt2b+CKUp7km6P TgGt/CbTiQidAVcd0PcwNGl1yqsMwU4nrEWlP/OWjfnYL+SoN60YSmHJ0r5EMbIL zRSPBMmmYpdM/kvLVZe85nNmcmdhAH+HKJLXct/k+ES/JqI1G7yjQmLD8/PHBySD mKBnYcwZ9soRUI3kuz+GXQfin4ZDoqnrvPH8pNXAJeJ3Bof2tF0LPDXNBbgLa3U= =WAJU -----END PGP SIGNATURE----- --/CMXFb8mCYhr2S8D--