From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751904AbcBZJzH (ORCPT ); Fri, 26 Feb 2016 04:55:07 -0500 Received: from mail-pf0-f169.google.com ([209.85.192.169]:35223 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbcBZJy6 (ORCPT ); Fri, 26 Feb 2016 04:54:58 -0500 Date: Fri, 26 Feb 2016 15:24:56 +0530 From: Viresh Kumar To: Jisheng Zhang Cc: daniel.lezcano@linaro.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clockevents/drivers/dw_apb_timer: Implement ->set_state_oneshot_stopped() Message-ID: <20160226095456.GD5823@vireshk-i7> References: <1456479957-1561-1-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456479957-1561-1-git-send-email-jszhang@marvell.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26-02-16, 17:45, Jisheng Zhang wrote: > The dw_apb_timer only "supports PERIODIC mode and their drivers emulate > ONESHOT over that" as described in commit 8fff52fd5093 ("clockevents: > Introduce CLOCK_EVT_STATE_ONESHOT_STOPPED state"). > > Inspired by Viresh, I think the dw_apb_timer also needs to implement > the set_state_oneshot_stopped() which is called by the clkevt core, > when the next event is required at an expiry time of 'KTIME_MAX'. This > normally happens with NO_HZ_{IDLE|FULL} in both LOWRES/HIGHRES modes. > > This patch makes the clockevent device to stop on such an event, to > avoid spurious interrupts, as explained by the above commit. > > Signed-off-by: Jisheng Zhang > --- > drivers/clocksource/dw_apb_timer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clocksource/dw_apb_timer.c b/drivers/clocksource/dw_apb_timer.c > index 6334526..797505a 100644 > --- a/drivers/clocksource/dw_apb_timer.c > +++ b/drivers/clocksource/dw_apb_timer.c > @@ -264,6 +264,7 @@ dw_apb_clockevent_init(int cpu, const char *name, unsigned rating, > dw_ced->ced.set_state_shutdown = apbt_shutdown; > dw_ced->ced.set_state_periodic = apbt_set_periodic; > dw_ced->ced.set_state_oneshot = apbt_set_oneshot; > + dw_ced->ced.set_state_oneshot_stopped = apbt_shutdown; > dw_ced->ced.tick_resume = apbt_resume; > dw_ced->ced.set_next_event = apbt_next_event; > dw_ced->ced.irq = dw_ced->timer.irq; Reviewed-by: Viresh Kumar -- viresh