From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754117AbcBZKgv (ORCPT ); Fri, 26 Feb 2016 05:36:51 -0500 Received: from mga04.intel.com ([192.55.52.120]:15510 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbcBZKgt (ORCPT ); Fri, 26 Feb 2016 05:36:49 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="55203038" Date: Fri, 26 Feb 2016 12:36:44 +0200 From: Heikki Krogerus To: "Shevchenko, Andriy" Cc: "rjw@rjwysocki.net" , "mika.westerberg@linux.intel.com" , "linux-kernel@vger.kernel.org" , "John.Youn@synopsys.com" Subject: Re: [PATCH 2/2] device property: fix for a case of use-after-free Message-ID: <20160226103644.GE29434@kuha.fi.intel.com> References: <1456152641-127948-1-git-send-email-heikki.krogerus@linux.intel.com> <1456152641-127948-3-git-send-email-heikki.krogerus@linux.intel.com> <1456155650.13244.24.camel@linux.intel.com> <1456160688.13244.30.camel@intel.com> <20160226080434.GD29434@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160226080434.GD29434@kuha.fi.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2016 at 10:04:34AM +0200, Heikki Krogerus wrote: > On Mon, Feb 22, 2016 at 05:04:04PM +0000, Shevchenko, Andriy wrote: > > Considering this, perhaps better solution is to convert last lines to > > > > if (!IS_ERR(fwnode) && is_pset_node(fwnode)) { > >   set_secondary_fwnode(dev, NULL); > >   pset_free_set(to_pset_node(fwnode)); > > } > > After some testing, this seems to work. I'll prepare v2 and use it. Sorry, I was a bit too hasty with my answer. So that also does not work in case the pset provides the fwnode. Thanks, -- heikki