From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422836AbcBZQiP (ORCPT ); Fri, 26 Feb 2016 11:38:15 -0500 Received: from smtprelay0070.hostedemail.com ([216.40.44.70]:47236 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932177AbcBZQiK (ORCPT ); Fri, 26 Feb 2016 11:38:10 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:966:967:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1543:1593:1594:1711:1730:1747:1777:1792:1963:2196:2199:2393:2525:2553:2560:2563:2682:2685:2693:2859:2899:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3355:3622:3865:3866:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:4385:4605:5007:6119:6261:6742:7514:7576:7875:7903:8660:9025:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12555:12740:13148:13230:13255:13891:14096:14097:14659:21080:21324:30012:30034:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:7,LUA_SUMMARY:none X-HE-Tag: fact28_6415cf855ce0b X-Filterd-Recvd-Size: 4884 Date: Fri, 26 Feb 2016 11:38:06 -0500 From: Steven Rostedt To: js1304@gmail.com Cc: Andrew Morton , Michal Nazarewicz , Minchan Kim , Mel Gorman , Vlastimil Babka , "Kirill A. Shutemov" , Sergey Senozhatsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Joonsoo Kim Subject: Re: [PATCH v4 2/2] mm/page_ref: add tracepoint to track down page reference manipulation Message-ID: <20160226113806.27002b82@gandalf.local.home> In-Reply-To: <1456448282-897-2-git-send-email-iamjoonsoo.kim@lge.com> References: <1456448282-897-1-git-send-email-iamjoonsoo.kim@lge.com> <1456448282-897-2-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Feb 2016 09:58:02 +0900 js1304@gmail.com wrote: > From: Joonsoo Kim > > CMA allocation should be guaranteed to succeed by definition, but, > unfortunately, it would be failed sometimes. It is hard to track down > the problem, because it is related to page reference manipulation and > we don't have any facility to analyze it. > > This patch adds tracepoints to track down page reference manipulation. > With it, we can find exact reason of failure and can fix the problem. > Following is an example of tracepoint output. (note: this example is > stale version that printing flags as the number. Recent version will > print it as human readable string.) > > <...>-9018 [004] 92.678375: page_ref_set: pfn=0x17ac9 flags=0x0 count=1 mapcount=0 mapping=(nil) mt=4 val=1 > <...>-9018 [004] 92.678378: kernel_stack: > => get_page_from_freelist (ffffffff81176659) > => __alloc_pages_nodemask (ffffffff81176d22) > => alloc_pages_vma (ffffffff811bf675) > => handle_mm_fault (ffffffff8119e693) > => __do_page_fault (ffffffff810631ea) > => trace_do_page_fault (ffffffff81063543) > => do_async_page_fault (ffffffff8105c40a) > => async_page_fault (ffffffff817581d8) > [snip] > <...>-9018 [004] 92.678379: page_ref_mod: pfn=0x17ac9 flags=0x40048 count=2 mapcount=1 mapping=0xffff880015a78dc1 mt=4 val=1 > [snip] > ... > ... > <...>-9131 [001] 93.174468: test_pages_isolated: start_pfn=0x17800 end_pfn=0x17c00 fin_pfn=0x17ac9 ret=fail > [snip] > <...>-9018 [004] 93.174843: page_ref_mod_and_test: pfn=0x17ac9 flags=0x40068 count=0 mapcount=0 mapping=0xffff880015a78dc1 mt=4 val=-1 ret=1 > => release_pages (ffffffff8117c9e4) > => free_pages_and_swap_cache (ffffffff811b0697) > => tlb_flush_mmu_free (ffffffff81199616) > => tlb_finish_mmu (ffffffff8119a62c) > => exit_mmap (ffffffff811a53f7) > => mmput (ffffffff81073f47) > => do_exit (ffffffff810794e9) > => do_group_exit (ffffffff81079def) > => SyS_exit_group (ffffffff81079e74) > => entry_SYSCALL_64_fastpath (ffffffff817560b6) > > This output shows that problem comes from exit path. In exit path, > to improve performance, pages are not freed immediately. They are gathered > and processed by batch. During this process, migration cannot be possible > and CMA allocation is failed. This problem is hard to find without this > page reference tracepoint facility. > > Enabling this feature bloat kernel text 30 KB in my configuration. > > text data bss dec hex filename > 12127327 2243616 1507328 15878271 f2487f vmlinux_disabled > 12157208 2258880 1507328 15923416 f2f8d8 vmlinux_enabled > > Note that, due to header file dependency problem between mm.h and > tracepoint.h, this feature has to open code the static key functions > for tracepoints. Proposed by Steven Rostedt in following link. > > https://lkml.org/lkml/2015/12/9/699 > > v3: > o Add commit description and code comment why this patch open code > the static key functions for tracepoints. > o Notify that example is stale version. > o Add "depends on TRACEPOINTS". > > v2: > o Use static key of each tracepoints to avoid function call overhead > when tracepoints are disabled. > o Print human-readable page flag thanks to newly introduced %pgp option. > o Add more description to Kconfig.debug. > > Acked-by: Michal Nazarewicz > Signed-off-by: Joonsoo Kim Acked-by: Steven Rostedt -- Steve