From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422773AbcBZRph (ORCPT ); Fri, 26 Feb 2016 12:45:37 -0500 Received: from smtprelay0123.hostedemail.com ([216.40.44.123]:54957 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932763AbcBZRpf (ORCPT ); Fri, 26 Feb 2016 12:45:35 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2904:3138:3139:3140:3141:3142:3353:3622:3866:3867:3871:3874:5007:6238:6261:6742:7875:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12555:12740:13255:14659:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: baby43_6a948fbefb80c X-Filterd-Recvd-Size: 3393 Date: Fri, 26 Feb 2016 12:45:31 -0500 From: Steven Rostedt To: Alexander Potapenko Cc: adech.fo@gmail.com, cl@linux.com, dvyukov@google.com, akpm@linux-foundation.org, ryabinin.a.a@gmail.com, iamjoonsoo.kim@lge.com, js1304@gmail.com, kcc@google.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 4/7] arch, ftrace: For KASAN put hard/soft IRQ entries into separate sections Message-ID: <20160226124531.365bc27d@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Feb 2016 14:30:43 +0100 Alexander Potapenko wrote: > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > index c2b340e..4da848d 100644 > --- a/include/linux/ftrace.h > +++ b/include/linux/ftrace.h > @@ -799,16 +799,6 @@ ftrace_push_return_trace(unsigned long ret, unsigned long func, int *depth, > */ > #define __notrace_funcgraph notrace > > -/* > - * We want to which function is an entrypoint of a hardirq. > - * That will help us to put a signal on output. > - */ > -#define __irq_entry __attribute__((__section__(".irqentry.text"))) > - > -/* Limits of hardirq entrypoints */ > -extern char __irqentry_text_start[]; > -extern char __irqentry_text_end[]; > - > #define FTRACE_NOTRACE_DEPTH 65536 > #define FTRACE_RETFUNC_DEPTH 50 > #define FTRACE_RETSTACK_ALLOC_SIZE 32 > @@ -845,7 +835,6 @@ static inline void unpause_graph_tracing(void) > #else /* !CONFIG_FUNCTION_GRAPH_TRACER */ > > #define __notrace_funcgraph > -#define __irq_entry > #define INIT_FTRACE_GRAPH > > static inline void ftrace_graph_init_task(struct task_struct *t) { } > diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h > index 0e95fcc..1dcecaf 100644 > --- a/include/linux/interrupt.h > +++ b/include/linux/interrupt.h > @@ -673,4 +673,24 @@ extern int early_irq_init(void); > extern int arch_probe_nr_irqs(void); > extern int arch_early_irq_init(void); > > +#if defined(CONFIG_FUNCTION_GRAPH_TRACER) || defined(CONFIG_KASAN) > +/* > + * We want to know which function is an entrypoint of a hardirq or a softirq. > + */ > +#define __irq_entry __attribute__((__section__(".irqentry.text"))) > +#define __softirq_entry \ > + __attribute__((__section__(".softirqentry.text"))) > + > +/* Limits of hardirq entrypoints */ > +extern char __irqentry_text_start[]; > +extern char __irqentry_text_end[]; > +/* Limits of softirq entrypoints */ > +extern char __softirqentry_text_start[]; > +extern char __softirqentry_text_end[]; > + > +#else > +#define __irq_entry > +#define __softirq_entry > +#endif > + > #endif > diff --git a/kernel/softirq.c b/kernel/softirq.c Acked-by: Steven Rostedt -- Steve