Re: [PATCH 1/3] usb: USB Type-C Connector Class

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

Hi Oliver,

I've missed couple of your questions..

> > > Furthermore, do these files support poll?
> 
> At least the current role and mode can change, so in principle
> poll() makes sense.

Yes I agree. I'll add support for polling.

> > > And lastly we can get "Attention" as a message connected
> > > with a connector in an alternate mode. How does user space
> > > learn about that?
> > 
> > The class should notify the userspace with uevent on
> > connection/disconnection regardless what is being connected, or what
> > mode the connector enters initially.
> 
> Yes, but "Attention" in the sense of 6.4.4.3.6 of the PD spec.
> Does this need to be handled in the kernel? Do we generate a uevent
> for that?

OK, got it. Not for now, but it makes sense, though for example with
UCSI we don't receive any notification in case of Attention, so this
is something that is not going to be always available.

I'm going to be away next week, but I'm planning to prepare v2 of
these patches after that. I'll also propose something for handling
Attention Command and polling then.


Thanks,

-- 
heikki