From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933628AbcBZPnK (ORCPT <rfc822;w@1wt.eu>);
	Fri, 26 Feb 2016 10:43:10 -0500
Received: from mx2.suse.de ([195.135.220.15]:43843 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753896AbcBZPnI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 26 Feb 2016 10:43:08 -0500
Date: Fri, 26 Feb 2016 16:43:06 +0100
From: Petr Mladek <pmladek@suse.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, Oleg Nesterov <oleg@redhat.com>,
        Tejun Heo <tj@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jiri Kosina <jkosina@suse.cz>, Borislav Petkov <bp@suse.de>,
        Michal Hocko <mhocko@suse.cz>, linux-mm@kvack.org,
        Vlastimil Babka <vbabka@suse.cz>, linux-api@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 10/20] kthread: Better support freezable kthread
 workers
Message-ID: <20160226154305.GJ3305@pathway.suse.cz>
References: <1456153030-12400-1-git-send-email-pmladek@suse.com>
 <1456153030-12400-11-git-send-email-pmladek@suse.com>
 <20160225130115.GJ6357@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160225130115.GJ6357@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu 2016-02-25 14:01:15, Peter Zijlstra wrote:
> On Mon, Feb 22, 2016 at 03:57:00PM +0100, Petr Mladek wrote:
> > +enum {
> > +	KTW_FREEZABLE		= 1 << 2,	/* freeze during suspend */
> > +};
> 
> Weird value; what was wrong with 1 << 0 ?

Heh, the flag was inspired by

	WQ_FREEZABLE		= 1 << 2, /* freeze during suspend */

from include/linux/workqueue.h. But it does not really matter.
I could change it to 1 << 0 if it makes people less curious.

Thanks a lot for review,
Petr