From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933757AbcBZRFw (ORCPT ); Fri, 26 Feb 2016 12:05:52 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:43913 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753895AbcBZRFv (ORCPT ); Fri, 26 Feb 2016 12:05:51 -0500 Date: Fri, 26 Feb 2016 18:05:45 +0100 From: Andrew Lunn To: John Crispin Cc: "Fred Chang (?????????)" , "Steven Liu (?????????)" , netdev@vger.kernel.org, "Carlos Huang (?????????)" , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , "David S. Miller" , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW) Message-ID: <20160226170545.GE12022@lunn.ch> References: <1456496504-50429-1-git-send-email-blogic@openwrt.org> <1456496504-50429-4-git-send-email-blogic@openwrt.org> <20160226151813.GD12022@lunn.ch> <56D06E3F.1020100@openwrt.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56D06E3F.1020100@openwrt.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > the problem here is that on one side people complain about vendors not > sending code upstream. once they start being a good citizen and provide > funding to send stuff upstream the feedback tends to be very bad as seen > here. we are planning on doing a DSA driver but one step at a time. this > kind of feedback will inevitably lead to vendors doing second thoughts > of upstream contributions. I think it is great a vendor is providing funding to get code upstream. However, that code needs to conform with current kernel architecture and design philosophy. We as a community also need to be consistent. We have recently push back on Microchip with there LAN9352 who want to do something very similar, introduce the MAC and a very dumb switch driver. They are now looking at what it means to do a DSA driver. There is also talk of writing a DSA driver for the ks8995 family. As David said recently, a year ago this probably would of been accepted. But now, switches need to be DSA or switchdev. Andrew