From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756105AbcB0IjG (ORCPT <rfc822;w@1wt.eu>);
	Sat, 27 Feb 2016 03:39:06 -0500
Received: from mga14.intel.com ([192.55.52.115]:3768 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753316AbcB0IjE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 27 Feb 2016 03:39:04 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,507,1449561600"; 
   d="scan'208";a="896117858"
Date: Sat, 27 Feb 2016 10:38:57 +0200
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "dbasehore ." <dbasehore@chromium.org>
Cc: Linux-pm mailing list <linux-pm@vger.kernel.org>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete
Message-ID: <20160227083857.GY1770@lahna.fi.intel.com>
References: <1456359748-22838-1-git-send-email-dbasehore@chromium.org>
 <1456359748-22838-3-git-send-email-dbasehore@chromium.org>
 <20160227072641.GX1770@lahna.fi.intel.com>
 <CAGAzgsoAiL0Xmqi3gzNyuQ6kf47UiEsO3V6-WMgkd5-Wu2y42Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGAzgsoAiL0Xmqi3gzNyuQ6kf47UiEsO3V6-WMgkd5-Wu2y42Q@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 27, 2016 at 12:10:03AM -0800, dbasehore . wrote:
> A device is not able to use direct complete if its children do not
> also use direct complete. Even though the SCSI layer leaves devices
> runtime suspended, the way it does it still prevents its parent from
> using direct complete.

Okay.

Do you need to provide ->complete() hook that then resumes the device
when system is resumed (since the device resume hook is never called
when direct_complete is set)? Along the lines of
pm_complete_with_resume_check().