From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756688AbcB0PSh (ORCPT <rfc822;w@1wt.eu>);
	Sat, 27 Feb 2016 10:18:37 -0500
Received: from casper.infradead.org ([85.118.1.10]:59182 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756331AbcB0PSf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 27 Feb 2016 10:18:35 -0500
Date: Sat, 27 Feb 2016 16:18:32 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Oleg Nesterov <oleg@redhat.com>,
        Tejun Heo <tj@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jiri Kosina <jkosina@suse.cz>, Borislav Petkov <bp@suse.de>,
        Michal Hocko <mhocko@suse.cz>, linux-mm@kvack.org,
        Vlastimil Babka <vbabka@suse.cz>, linux-api@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 04/20] kthread: Add drain_kthread_worker()
Message-ID: <20160227151832.GG6356@twins.programming.kicks-ass.net>
References: <1456153030-12400-1-git-send-email-pmladek@suse.com>
 <1456153030-12400-5-git-send-email-pmladek@suse.com>
 <20160225123551.GG6357@twins.programming.kicks-ass.net>
 <20160226152309.GH3305@pathway.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160226152309.GH3305@pathway.suse.cz>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 26, 2016 at 04:23:09PM +0100, Petr Mladek wrote:
> I do not have a strong opinion here. On one hand, such a check might
> help with debugging. On the other hand, workqueues have happily lived
> without it for years.

TJ and me have a different view on these things. I'm always for the
strictest possible semantics with strong validation. TJ always worries a
lot about existing users.

Luckily, you don't have users yet :-)