From: Antonio Ospite <ao2@ao2.it>
To: Jannik Becher <becher.jannik@gmail.com>
Cc: crope@iki.fi, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jannik Becher <Becher.Jannik@gmail.com>
Subject: Re: [PATCH] Media: usb: hackrf: fixed a style issue
Date: Sat, 27 Feb 2016 21:14:10 +0100 [thread overview]
Message-ID: <20160227211410.de7c8d21d1ab84c5870221cf@ao2.it> (raw)
In-Reply-To: <1456602156-25011-1-git-send-email-Becher.Jannik@gmail.com>
On Sat, 27 Feb 2016 20:42:36 +0100
Jannik Becher <becher.jannik@gmail.com> wrote:
> Fixed a coding style issue.
>
You should be more specific: which style issue?
See also my comment below.
> Signed-off-by: Jannik Becher <Becher.Jannik@gmail.com>
> ---
> drivers/media/usb/hackrf/hackrf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c
> index 9e700ca..186ef2d 100644
> --- a/drivers/media/usb/hackrf/hackrf.c
> +++ b/drivers/media/usb/hackrf/hackrf.c
> @@ -249,6 +249,7 @@ static int hackrf_set_params(struct hackrf_dev *dev)
> unsigned int uitmp, uitmp1, uitmp2;
> const bool rx = test_bit(RX_ON, &dev->flags);
> const bool tx = test_bit(TX_ON, &dev->flags);
> +
> static const struct {
> u32 freq;
> } bandwidth_lut[] = {
If this has been found by scripts/checkpatch.pl as:
WARNING: Missing a blank line after declarations
#252: FILE: drivers/media/usb/hackrf/hackrf.c:252:
+ const bool tx = test_bit(TX_ON, &dev->flags);
+ static const struct {
it is a false positive, as the code which follows the blank line is a
declaration too.
Ciao ciao,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
prev parent reply other threads:[~2016-02-27 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 19:42 Jannik Becher
2016-02-27 20:14 ` Antonio Ospite [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160227211410.de7c8d21d1ab84c5870221cf@ao2.it \
--to=ao2@ao2.it \
--cc=becher.jannik@gmail.com \
--cc=crope@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®