From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757598AbcB1NJy (ORCPT ); Sun, 28 Feb 2016 08:09:54 -0500 Received: from mail-ob0-f193.google.com ([209.85.214.193]:32962 "EHLO mail-ob0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756975AbcB1NJw (ORCPT ); Sun, 28 Feb 2016 08:09:52 -0500 Date: Sun, 28 Feb 2016 08:09:50 -0500 From: Tejun Heo To: Bhaktipriya Shridhar Cc: gregkh@linuxfoundation.org, aaro.koskinen@iki.fi, cristina.moraru09@gmail.com, avid.daney@cavium.com, david.daney@cavium.com, ralf@linux-mips.org, paul.martin@codethink.co.uk, arnd@arndb.de, joe@perches.com, aybuke.147@gmail.com, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH v3] staging: octeon: Convert create_singlethread_workqueue() Message-ID: <20160228130950.GJ3965@htj.duckdns.org> References: <20160227175147.GA28115@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160227175147.GA28115@Karyakshetra> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Sat, Feb 27, 2016 at 11:21:47PM +0530, Bhaktipriya Shridhar wrote: > With conccurency managed workqueues, use of dedicated workqueues can > be replaced by system_wq. Drop cvm_oct_poll_queue by using system_wq. > > There are multiple work items per cvm_oct_poll_queue (viz. > cvm_oct_rx_refill_work, port_periodic_work) and different > cvm_oct_poll_queues need not be be ordered. Hence, concurrency > can be increased by switching to system_wq. > > All work items are sync canceled in cvm_oct_remove() so it > is guaranteed that no work is in flight by the time exit path runs. > > Signed-off-by: Bhaktipriya Shridhar For the workqueue part, Acked-by: Tejun Heo Thanks. -- tejun