From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755041AbcB2LhO (ORCPT ); Mon, 29 Feb 2016 06:37:14 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45824 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753628AbcB2LhL (ORCPT ); Mon, 29 Feb 2016 06:37:11 -0500 Date: Mon, 29 Feb 2016 20:37:05 +0900 From: Mark Brown To: Maarten ter Huurne Cc: Wenyou Yang , Zubair Lutfullah Kakakhel , Liam Girdwood , linux-kernel@vger.kernel.org Message-ID: <20160229113705.GA18327@sirena.org.uk> References: <1456674809-16422-1-git-send-email-maarten@treewalker.org> <1456674809-16422-5-git-send-email-maarten@treewalker.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2KJW3tE6NdndVjxo" Content-Disposition: inline In-Reply-To: <1456674809-16422-5-git-send-email-maarten@treewalker.org> X-Cookie: Adapt. Enjoy. Survive. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 122.212.32.58 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 5/7] regulator: act8865: Pass of_node via act8865_regulator_data X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2KJW3tE6NdndVjxo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 28, 2016 at 04:53:27PM +0100, Maarten ter Huurne wrote: > + struct regulator_config config =3D { > + .dev =3D dev, > + .regmap =3D act8865->regmap, > + .driver_data =3D act8865, > + }; > + struct act8865_regulator_data *rdata; > struct regulator_dev *rdev; > =20 > - config.dev =3D dev; > - config.init_data =3D act8865_get_init_data(desc->id, pdata); > - config.of_node =3D of_node[i]; > - config.driver_data =3D act8865; > - config.regmap =3D act8865->regmap; This appears to be doing some unrelated refectoring of the code which should be in a separate commit to make review clearer. --2KJW3tE6NdndVjxo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW1C1gAAoJECTWi3JdVIfQI94H/i+N6rLZqEJiWWNY6lfgL/nf Zn5KGeCaH6/jJhXcJ/RZhg2Jqv6AsRBWlJsLykXs9Y+XyAe579U0HukmGQ210P3N jqaQCTR8CfI9JW1qtBJJ20lJ5myZM9MFq9Dfb5q+gtHpSYQW25rwrAbI+kAkIqXg ANlpPA8d92T/IzPCXfD3864qtnUCmIZ3RCIxoPgFu0ZyGg0Gnfp+FNBYuKZjLosN dOzSKhKniteoiywC3XXA18IZF1E1JndDzZygnYjx/OEvEs+J54YnIbL8eF1LcZx3 i0M+Z0JITr4d789+AoWOmym4Rc8wczMwJAG9GYKk3wkDaTXtg2BXwCdlNxW06t0= =yGlV -----END PGP SIGNATURE----- --2KJW3tE6NdndVjxo--