From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752826AbcB2XRw (ORCPT ); Mon, 29 Feb 2016 18:17:52 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47339 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbcB2XRv (ORCPT ); Mon, 29 Feb 2016 18:17:51 -0500 Date: Mon, 29 Feb 2016 15:17:49 -0800 From: Andrew Morton To: Brian Starkey Cc: Catalin Marinas , Dan Williams , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 4/4] drivers: dma-coherent: use memset_io for DMA_MEMORY_IO mappings Message-Id: <20160229151749.a972ae993adffb667140548d@linux-foundation.org> In-Reply-To: <7942c970d1071643f3763de6eaf6d55a3945a069.1456225103.git.brian.starkey@arm.com> References: <7942c970d1071643f3763de6eaf6d55a3945a069.1456225103.git.brian.starkey@arm.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Feb 2016 16:09:24 +0000 Brian Starkey wrote: > Use memset_io() for DMA_MEMORY_IO mappings which are mapped as I/O > memory, and regular memset() for DMA_MEMORY_MAP mappings. > > This fixes the below alignment fault on arm64 for DMA_MEMORY_IO > mappings, where memset() uses the DC ZVA instruction which is > invalid on device memory. What's the urgency of this fix? "Hair on fire needed in stable asap" or "Nice to have in there for 4.6" or what?