From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753111AbcB2QWl (ORCPT ); Mon, 29 Feb 2016 11:22:41 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33729 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbcB2QWk (ORCPT ); Mon, 29 Feb 2016 11:22:40 -0500 Date: Mon, 29 Feb 2016 21:52:20 +0530 From: Sudip Mukherjee To: Takashi Iwai Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: mts64: fix NULL pointer dereference Message-ID: <20160229162220.GA8495@sudip-laptop> References: <1456748010-17038-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 29, 2016 at 01:24:24PM +0100, Takashi Iwai wrote: > On Mon, 29 Feb 2016 13:13:30 +0100, > Sudip Mukherjee wrote: > > > > While registering pardev, the irq_func was also registered. As a > > result when we tried to probe for the card, an interrupt was generated > > and in the ISR we tried to dereference private_data. But private_data > > is still NULL as we have not yet done snd_mts64_create(). Lets probe > > for the card after mts64 is created. > > > > Reported-by: Fengguang Wu > > Fixes: 94a573500d48 ("ALSA: mts64: use new parport device model") > > Signed-off-by: Sudip Mukherjee > > Applied, thanks. Thanks, I will wait for one day for any report from 0day and then send you the similar patch for portman. BTW, i lost that auction of portman. regards sudip