mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: kernel test robot <ying.huang@linux.intel.com>,
	Mel Gorman <mgorman@suse.de>,
	lkp@01.org, LKML <linux-kernel@vger.kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>,
	Darren Hart <dvhart@linux.intel.com>, Chris Mason <clm@fb.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Davidlohr Bueso <dbueso@suse.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [lkp] [futex] 65d8fc777f: +25.6% will-it-scale.per_process_ops
Date: Mon, 29 Feb 2016 09:37:47 -0800	[thread overview]
Message-ID: <20160229173747.GA17288@linux-uzut.site> (raw)
In-Reply-To: <20160229093708.GA21037@gmail.com>

On Mon, 29 Feb 2016, Ingo Molnar wrote:

>
>* kernel test robot <ying.huang@linux.intel.com> wrote:
>
>> FYI, we noticed the below changes on
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> commit 65d8fc777f6dcfee12785c057a6b57f679641c90 ("futex: Remove requirement for
>> lock_page() in get_futex_key()")
>
>I have asked for this before, but let me try again: could you _PLEASE_ make these
>emails more readable?
>
>For example what are the 'below changes'? Changes in the profile output? Profiles
>always change from run to run, so that alone is not informative.
>
>Also, there are a lot of changes - which ones prompted the email to be generated?
>
>All in one, this email is hard to parse, because it just dumps a lot of
>information with very little explanatory structure for someone not versed in their
>format. Please try to create an easy to parse 'story' that leads the reader
>towards what you want these emails to tell - not just a raw dump of seemingly
>unconnected pieces of data ...
>↓
>Thanks,
>
>	Ingo
>
>>
>>
>> =========================================================================================
>> compiler/cpufreq_governor/kconfig/rootfs/tbox_group/test/testcase:
>>   gcc-4.9/performance/x86_64-rhel/debian-x86_64-2015-02-07.cgz/lkp-sbx04/futex1/will-it-scale

If I'm reading this correctly, it is similar to what I measured wrt ~lockleless get_futex_key()
stuff using the perf runs, with similar performance improvement numbers (per process/thread ops).
The futex1 test will just pound on FUTEX_WAKE without anyone actually blocked on a futex, so it
mainly measures the key/hashing part of the operation.

Thanks,
Davidlohr

  reply	other threads:[~2016-02-29 17:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29  8:36 kernel test robot
2016-02-29  9:37 ` Ingo Molnar
2016-02-29 17:37   ` Davidlohr Bueso [this message]
2016-03-01  8:38   ` [LKP] " Huang, Ying
2016-03-18  6:12   ` Huang, Ying
2016-03-18  8:35     ` Thomas Gleixner
2016-03-21  2:53       ` Huang, Ying
2016-03-21  8:00         ` Thomas Gleixner
2016-03-21  8:42           ` Huang, Ying
2016-03-28 17:14             ` Darren Hart
2016-03-29  1:12               ` Huang, Ying
2016-03-29  5:17                 ` Darren Hart
2016-03-29  5:57                   ` Huang, Ying
2016-03-29  7:39             ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160229173747.GA17288@linux-uzut.site \
    --to=dave@stgolabs.net \
    --cc=a.p.zijlstra@chello.nl \
    --cc=bigeasy@linutronix.de \
    --cc=clm@fb.com \
    --cc=dbueso@suse.de \
    --cc=dvhart@linux.intel.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=mgorman@suse.de \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=ying.huang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome